[alsa-devel] [PATCH] max98357a:add dai without triggered by pcm

Mark Brown broonie at kernel.org
Mon Apr 1 05:24:46 CEST 2019


On Fri, Mar 29, 2019 at 09:51:59AM +0800, tony.zou.hq at gmail.com wrote:

> max98357a's enable pin need setting independently
> when max98357a is shared I2S with other codec.

> add dai "max98357a-hifi" without pcm trigger,
> and use "Spk PA Switch" to set the enable pin.

This sounds like a really bad idea - if you have multiple CODECs on a
single DAI link tell the core about it, don't try to bodge around it.
There's support for multiple CODECs on a DAI link already.

> +static const char * const ext_spk_text[] = {
> +	"Off", "On"
> +};

Simple on/off switches should be normal switch controls, not enums.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190401/c88cd811/attachment.sig>


More information about the Alsa-devel mailing list