[alsa-devel] [PATCH 2/2] sound: soc: wm8903: Cut gpio_base data

Linus Walleij linus.walleij at linaro.org
Wed Sep 19 04:07:54 CEST 2018


On Tue, Sep 18, 2018 at 5:09 PM Mark Brown <broonie at kernel.org> wrote:
> On Tue, Sep 18, 2018 at 04:51:23PM -0700, Linus Walleij wrote:
>
> > Since there are no boards defining platform data (hence patch 1)
> > I assume all users are using device tree and thus dynamic
> > GPIO number assignment, so this can go.
>
> > Even if new board files are added they should use machine
> > descriptor tables for referencing the individual GPIO chip and
> > offset. In this case by the label "wm8903" and local offset.
>
> I tend to worry about breaking out of tree users unless there's an
> active reason to do it, is there something coming along - this looked
> more like just a cleanup?

This is to get rid of the global GPIO numberspace, little by little.
As long as we hardcode the base of the GPIO chip anywhere,
that numberspace prevails.

Yours,
Linus Walleij


More information about the Alsa-devel mailing list