[alsa-devel] [asoc:for-4.20 333/424] sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?

Takashi Iwai tiwai at suse.de
Wed Sep 12 14:01:05 CEST 2018


On Wed, 12 Sep 2018 13:31:28 +0200,
Mark Brown wrote:
> 
> On Tue, Sep 11, 2018 at 08:59:16AM +0200, Takashi Iwai wrote:
> 
> > Hrm, the header file inclusion of pci_iomap() looks fairly
> > inconsistent over architectures.  SH doesn't include asm/pci_iomap.h
> > from asm/io.h.  And x86 includes it from linux/io-mapping.h.
> 
> > As a quick fix, we can just include <asm/pci_iomap.h> from
> > patch_ca0132.c, I suppose.
> 
> Not on x86 we can't, it's not there - asm/io.h seems safest AFAICT,
> everyone has it and both SH and x86 include the pci_iomap.h.

Hmm, the code does include <linux/io.h>, and it includes <asm/io.h>

I don't think arch/sh/include/asm/io.h includes the necessary thing.


Takashi


More information about the Alsa-devel mailing list