[alsa-devel] [asoc:for-4.20 333/424] sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?

[Takashi Iwai]

On Tue, 11 Sep 2018 07:29:10 +0200,
kbuild test robot wrote:
> 
> Hi Rakesh,
> 
> FYI, the error/warning still remains.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-4.20
> head:   1c8bc7b3de5e76cb89aacdc7be1475a028af505f
> commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492 [333/424] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 6bae5ea9498926440ffc883f3dbceb0adc65e492
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=sh 
> 
> All errors (new ones prefixed by >>):
> 
>    sound/pci/hda/patch_ca0132.c: In function 'patch_ca0132':
> >> sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'? [-Werror=implicit-function-declaration]
>       spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20);
>                        ^~~~~~~~~
>                        pcim_iomap

Hrm, the header file inclusion of pci_iomap() looks fairly
inconsistent over architectures.  SH doesn't include asm/pci_iomap.h
from asm/io.h.  And x86 includes it from linux/io-mapping.h.

As a quick fix, we can just include <asm/pci_iomap.h> from
patch_ca0132.c, I suppose.

I can fix it in my side, but the problem is that the change isn't
pulled into my tree yet.  So it must be fixed in Mark's tree, or Mark
send a pull request including this change and let me fix it.


thanks,

Takashi