[alsa-devel] [PATCH] ASoC: qdsp6: q6asm-dai: clean up a return

[Srinivas Kandagatla]

On 10/09/18 09:40, Dan Carpenter wrote:
> Smatch complains that if both "psubstream" and "csubstream" are NULL
> then "ret" is uninitialized.  That probably can't happen, but it's
> cleaner to just return zero anyway so let's do that.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Acked-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>

> 
> diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
> index 9db9a2944ef2..c75fab38905d 100644
> --- a/sound/soc/qcom/qdsp6/q6asm-dai.c
> +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
> @@ -493,7 +493,7 @@ static int q6asm_dai_pcm_new(struct snd_soc_pcm_runtime *rtd)
>   		}
>   	}
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static void q6asm_dai_pcm_free(struct snd_pcm *pcm)
>