[alsa-devel] [PATCH 1/5] ASoC: adau1761: Use the standard fall-through annotation

Lars-Peter Clausen lars at metafoo.de
Thu Oct 4 20:34:20 CEST 2018


On 10/04/2018 08:30 PM, Takashi Iwai wrote:
> As a preparatory patch for the upcoming -Wimplicit-fallthrough
> compiler checks, replace with the standard "fall through" annotation
> at the right place.  It has to be put right before the next label.
> 
> Signed-off-by: Takashi Iwai <tiwai at suse.de>

Looks good, but somebody else already sent the same awhile ago. I'm not
sure, maybe it did not get picked up:
https://patchwork.kernel.org/patch/10560465/?

> ---
>  sound/soc/codecs/adau1761.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/adau1761.c b/sound/soc/codecs/adau1761.c
> index be136e981653..bef3e9e74c26 100644
> --- a/sound/soc/codecs/adau1761.c
> +++ b/sound/soc/codecs/adau1761.c
> @@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
>  			ARRAY_SIZE(adau1761_jack_detect_controls));
>  		if (ret)
>  			return ret;
> -	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
> +		/* fall through */
> +	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
>  		ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
>  			ARRAY_SIZE(adau1761_no_dmic_routes));
>  		if (ret)
> 



More information about the Alsa-devel mailing list