[alsa-devel] [PATCH v2] conf: Move UCM profile snippets into components subdirectory

[Takashi Iwai]

On Wed, 28 Nov 2018 12:09:17 +0100,
youling 257 wrote:
> 
> src/conf/ucm/chtrt5645/HiFi.conf, a lot of cset command, why quote
> PlatformEnableSeq.conf? although PlatformEnableSeq.conf is custom
> command for bytcr/chtbsw platform.
> if chtrt5645/HiFi.conf <searchdir:ucm> and
> <platforms/bytcr/PlatformEnableSeq.conf>, do you think the code is not
> neat?
> so i said revert "conf/ucm: bytcr-rt5645: Use the generic
> bytcr/PlatformEnableSeq.conf".
> chtrt5645-mono-speaker-analog-mic/HiFi.conf not quote PlatformEnableSeq.conf.

I don't get it.  The inclusion of PlatformEnableSeq.conf certainly
reduces lots of open cset calls that exited in cht5645/HiFi.conf.
That makes config more readable and maintainable.  Why this has to be
reverted?

There are still additional csets, yes.  But the inclusion of conf
snippet doesn't mean to replace all with the common pattern, in
general.


thanks,

Takashi

> 
> 2018-11-28 18:48 GMT+08:00, Takashi Iwai <tiwai at suse.de>:
> > On Wed, 28 Nov 2018 11:40:56 +0100,
> > youling 257 wrote:
> >>
> >> I'm still not see '<searchdir:ucm>' in the
> >> src/conf/ucm/chtrt5645/HiFi.conf,
> >> if needn't '<searchdir:ucm>', so can remove '<searchdir:ucm>' in other
> >> files?
> >> bytcr-rt5640/HiFi.conf, bytcr-rt5651/HiFi.conf, chtnau8824/HiFi.conf,
> >> ......, remove <searchdir:ucm>?
> >>
> >> my understand, no '<searchdir:ucm>',
> >> '<platforms/bytcr/PlatformEnableSeq.conf>' won't work.
> >
> > OK, point taken.  Yes, it's a missing piece.
> >
> > So, just adding <searchdir:ucm> makes things working on your machine,
> > right?
> >
> > If so, I'll refresh the patch to address it.
> >
> >
> > thanks,
> >
> > Takashi
> >
> >>
> >> 	EnableSequence [
> >> 		cdev "hw:chtrt5645"
> >>
> >> 		<platforms/bytcr/PlatformEnableSeq.conf>
> >>
> >> 		# Output Configuration
> >> 		cset "name='DAC1 L Mux' IF1 DAC"
> >> 		cset "name='DAC1 R Mux' IF1 DAC"
> >>
>