[alsa-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

Andy Shevchenko andy.shevchenko at gmail.com
Tue Nov 27 00:09:17 CET 2018


On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai <tiwai at suse.de> wrote:
>
> Hi,
>
> this is patch series I've hacked after useful conversation with
> Pavel.  Basically this adds a new LED trigger audio-mute and
> audio-micmute, and convert the HD-audio driver and the platform
> drivers to use the LED trigger instead of the ugly direct dynamic
> symbol binding.
>
> The latest version of patches are found in topic/leds-trigger branch
> in my sound git tree.
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
>
> As these are cross-tree patches, the branch above is based cleanly on
> v4.20-rc3, so that it can be merged well to multiple trees.
>
> Once after getting the ACK's, I'll add tags and fixate for merges.
>
> This patch series don't include huawei-wmi stuff; so Huawei patches
> need rework.  I already have some piece of changes for huawei-wmi, so
> please ping me if needed.
>
> I checked briefly on my Dell laptop, and a Thinkpad model.
> Wider tests are appreciated, of course.
>

Few minor comments, otherwise I like this series.
Acked-by: Andy Shevchenko <andy.shevchenko at gmail.com>
for PDx86 bits.

>
> thanks,
>
> Takashi
>
> ===
>
> Takashi Iwai (6):
>   leds: trigger: Introduce audio mute LED trigger
>   platform/x86: dell-laptop: Add micmute LED trigger support
>   platform/x86: thinkpad_acpi: Add audio mute LED classdev support
>   ALSA: hda - Support led audio trigger
>   platform/x86: dell-laptop: Drop superfluous exported function
>   platform/x86: thinkpad_acpi: Drop superfluous exported function
>
>  drivers/leds/trigger/Kconfig         |  7 +++
>  drivers/leds/trigger/Makefile        |  1 +
>  drivers/leds/trigger/ledtrig-audio.c | 45 +++++++++++++++++++
>  drivers/platform/x86/Kconfig         |  4 ++
>  drivers/platform/x86/dell-laptop.c   | 27 +++++++++---
>  drivers/platform/x86/thinkpad_acpi.c | 66 +++++++++++++++++++++-------
>  include/linux/dell-led.h             |  7 ---
>  include/linux/leds.h                 | 20 +++++++++
>  include/linux/thinkpad_acpi.h        | 16 -------
>  sound/pci/hda/dell_wmi_helper.c      | 48 --------------------
>  sound/pci/hda/hda_generic.c          | 31 +++++++++++++
>  sound/pci/hda/hda_generic.h          |  2 +
>  sound/pci/hda/patch_realtek.c        | 17 +++----
>  sound/pci/hda/thinkpad_helper.c      | 43 +++---------------
>  14 files changed, 194 insertions(+), 140 deletions(-)
>  create mode 100644 drivers/leds/trigger/ledtrig-audio.c
>  delete mode 100644 include/linux/dell-led.h
>  delete mode 100644 include/linux/thinkpad_acpi.h
>  delete mode 100644 sound/pci/hda/dell_wmi_helper.c
>
> --
> 2.19.1
>


-- 
With Best Regards,
Andy Shevchenko


More information about the Alsa-devel mailing list