[alsa-devel] [PATCH 2/2] ASoC: cs35l36: Add device tree documentation for CS35L36

Charles Keepax ckeepax at opensource.cirrus.com
Wed Nov 14 12:30:21 CET 2018


On Wed, Nov 14, 2018 at 09:31:11AM +0000, Charles Keepax wrote:
> On Tue, Nov 13, 2018 at 12:49:17PM -0600, James Schulman wrote:
> > Add device tree documentation for Cirrus Logic CS35L36
> > speaker amplifier
> > 
> > Signed-off-by: James Schulman <james.schulman at cirrus.com>
> > ---
> > +	cirrus,irq-config {
> > +		cirrus,irq-drive-select = <0x01>;
> > +		cirrus,irq-polarity = <0x00>;
> > +		cirrus,irq-gpio-select = <0x01>;
> > +		cirrus,irq-output-enable = <0x01>;
> > +		cirrus,irq-src-select = <0x01>;
> > +	};
> 
> This block is not documented in the rest of the document and
> looks like things that should really be controlled through other
> means. Presuming this is legacy and just needs removed?

Seems they are used by the driver so I guess best to document
them as a first step and we can review them from there.

Also looks like documentation is also missing for:

dcm-mode-enable
boost-ind-nanohenry

Thanks,
Charles


More information about the Alsa-devel mailing list