[alsa-devel] [PATCH - JACK plugin] jack: Use internal snd_pcm_state to reduce amount of additional variables

twischer at de.adit-jv.com twischer at de.adit-jv.com
Thu Mar 15 13:56:26 CET 2018


Hello Takashi,

> So in which situation would io->state and jack->state differ with each
> other?  Only DRAINING and XRUN, or in other cases?

I have extended the commit message:

Therefore this internal state variable is not always in sync with
io->state. In addition the internal state variable will be updated after
the corresponding callback function was processed and not before the
callback function was called (e.g. PREPARE and RUNNING).

Therefore the internal state will always contain the state
which is currently active.
It will keep the old state as long as the transition to the new one was successfully finished

See attached the updated patch which can be applied without conflicts.

Best regards,

Timo


More information about the Alsa-devel mailing list