[alsa-devel] [PATCH - alsa-utils 1/1] aplay: Fix wav file not being split on 32 bit platforms

Takashi Iwai tiwai at suse.de
Tue Mar 13 19:54:45 CET 2018


On Tue, 13 Mar 2018 19:51:24 +0100,
erwin wrote:
> 
> On my 32 bit armhf board arecord exits because of write() returning EFBIG
> when the output file size reaches 2147483647 bytes.
> 
> To fix this, include generated header file before system header files
> so that _FILE_OFFSET_BITS=64 is used properly, as required in documentation
> "man feature_test_macros".
> 
> Signed-off-by: erwin <nebelbank at posteo.de>

Thanks, the change looks good.  But sign-off is usually with a real
name, otherwise it doesn't make sense from the legal POV (that's the
reason of sign-off, after all).

If you really don't want to expose the name, I can drop it, of
course.  We don't mandate the sign-off in the user-space repos unlike
Linux kernel tree, so far.


Takashi


More information about the Alsa-devel mailing list