[alsa-devel] [PATCH 3/3] ASoC: Add Multi CPU DAI support in DAPM

Charles Keepax ckeepax at opensource.cirrus.com
Mon Mar 12 10:21:06 CET 2018


On Mon, Mar 12, 2018 at 11:07:52AM +0530, Shreyas NC wrote:
> On Fri, Mar 09, 2018 at 10:01:24PM +0530, Charles Keepax wrote:
> > On Tue, Mar 06, 2018 at 04:30:30PM +0530, Shreyas NC wrote:
> > > -static void dapm_connect_dai_link_widgets(struct snd_soc_card *card,
> > > -					  struct snd_soc_pcm_runtime *rtd)
> > > +static void dapm_check_dai_valid_widget(struct snd_soc_card *card,
> > > +					struct snd_soc_pcm_runtime *rtd,
> > > +					struct snd_soc_dai *codec_dai,
> > > +					struct snd_soc_dai *cpu_dai)
> > 
> > Not sure about the name here dapm_check_dai_valid_widget doesn't
> > sound like it should be adding paths, otherwise I think this one
> > looks ok.
> > 
> 
> Ok, does dapm_add_valid_widget() sound better?

Yeah that seems like a better name to me.

Thanks,
Charles


More information about the Alsa-devel mailing list