[alsa-devel] [RFC PATCH] ASoC: dapm: add support to pinctrl dapm

Mark Brown broonie at kernel.org
Mon Mar 5 16:52:08 CET 2018


On Mon, Mar 05, 2018 at 12:32:13PM +0000, srinivas.kandagatla at linaro.org wrote:

> +int dapm_pinctrl_event(struct snd_soc_dapm_widget *w,
> +		       struct snd_kcontrol *kcontrol, int event)
> +{
> +	struct snd_soc_dapm_pinctrl_priv *priv = w->priv;
> +	struct pinctrl *p = w->pinctrl;
> +	struct pinctrl_state *s;
> +
> +	if (!p || !priv)
> +		return -EIO;
> +
> +	soc_dapm_async_complete(w->dapm);

This doesn't look right - we're trying to synchronize with the DAPM
async queue from something that should be run inside that very queue.
What is this supposed to be doing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180305/8e6186a3/attachment-0001.sig>


More information about the Alsa-devel mailing list