[alsa-devel] [PATCH 2/3] ALSA: hda - Move in_pm accessors to HDA core

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 27 11:38:40 CEST 2018


Quoting Takashi Iwai (2018-06-27 10:10:33)
> The in_pm atomic in hdac_device is an important field used as a flag
> as well as a refcount for PM.  The existing snd_hdac_power_up/down
> helpers already refer to it in the HD-audio core code, while the code
> to actually setting the value (atomic_inc() / _dec()) is open-coded in
> HDA legacy side, which is hard to find.
> 
> This patch adds the helper functions to set/reset the in_pm counter to
> HDA core and use them in HDA legacy side, for making it clearer who /
> where the PM is managed.
> 
> There is no functional changes, just code refactoring.
> 
> Signed-off-by: Takashi Iwai <tiwai at suse.de>

Mechanical code change that helps explain what it is doing,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Alsa-devel mailing list