[alsa-devel] [[PATCH 0/9] ASoC: Intel: bytcr_rt5651: Cleanup (input mapping quirks)

Hans de Goede hdegoede at redhat.com
Sun Jun 24 16:06:25 CEST 2018


Hi Mark,

This series is mainly a cleanup series. In the beginning of the rt5651
machine driver some wrong assumptions were made, such as the headset
mic being attached to IN2 (it is on IN3 on the 7 machines I have access
to and on all otherwise known machines).

And also adding a quirk for a machine with the intmic on IN2, which
later got fixed with a new quirk for machines with 2 internal mics
on both IN1 and IN2 and moving the one machine with the IN2 quirk
over to the new IN1_IN2 quirk, leaving the IN2 quirk as an orphan
quirk for non existing hardware.

Then I made a similar mistake adding the IN2_HS_IN3 quirk, while I
should have used the IN1_HS_IN3 (which itself only exists because
the original IN1 quirk has the headset input mapping wrong),

TL;DR: it is a bit of a mess due to a number of wrong assumptions
about how the inputs where actually routed in the past.

This series cleans this all up in small commits / one bit a time and
refers the original commit messages in its commit messages.

Note patch 10/11 is not a cleanup patch, but is more or less the
reason I took a second look at all the quirks.

Regards,

Hans



More information about the Alsa-devel mailing list