[alsa-devel] [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

Robert Jarzmik robert.jarzmik at free.fr
Fri Jun 22 12:41:14 CEST 2018


Takashi Iwai <tiwai at suse.de> writes:

>> Special review query: review the "return of_node_get(node)", which
>> assumes that upon device removal, of_put_node(dev.of_node) will be
>> called...
>
> Is it really done automagically?  I couldn't spot it.
Neither could I ...

I based this on device_set_of_node_from_dev(), and the it "seemed" logical to me
that a device probed from devicetree would take a refcnt on the devicetree node.

As the "logical" conflicted with my search for the automagical of_node_get(), I
need the special review query.

Cheers.

-- 
Robert


More information about the Alsa-devel mailing list