[alsa-devel] [PATCH] ASoC: Intel: Boards: Add GLK Realtek Maxim I2S machine driver

[Pierre-Louis Bossart]

On 06/18/2018 10:46 AM, Naveen Manohar wrote:
> Patch adds Geminilake I2S machine driver which uses following codecs:
> RT5682 and MAX98357A.
Thanks Naveen. Looks good to me, just 4 nit-picks below on style 
(reverse x-mas tree order for variable definitions)
if you can fix, add my tag below and resubmit it'd nice.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

> +static int platform_clock_control(struct snd_soc_dapm_widget *w,
> +					struct snd_kcontrol *k, int  event)
> +{
> +	int ret = 0;
> +	struct snd_soc_dapm_context *dapm = w->dapm;
> +	struct snd_soc_card *card = dapm->card;
> +	struct snd_soc_dai *codec_dai;
here..
> +static int geminilake_rt5682_codec_init(struct snd_soc_pcm_runtime *rtd)
> +{
> +	int ret;
> +	struct snd_soc_jack *jack;
> +	struct snd_soc_dai *codec_dai = rtd->codec_dai;
> +	struct snd_soc_component *component = rtd->codec_dai->component;
> +	struct glk_card_private *ctx = snd_soc_card_get_drvdata(rtd->card);
and here
> +static int geminilake_rt5682_fe_init(struct snd_soc_pcm_runtime *rtd)
> +{
> +	int ret;
> +	struct snd_soc_dapm_context *dapm;
> +	struct snd_soc_component *component = rtd->cpu_dai->component;
and here
> +static int glk_card_late_probe(struct snd_soc_card *card)
> +{
> +	struct glk_card_private *ctx = snd_soc_card_get_drvdata(card);
> +	struct snd_soc_component *component = NULL;
> +	char jack_name[NAME_SIZE];
> +	struct glk_hdmi_pcm *pcm;
> +	int err, i = 0;
one last, i find it more readable to have one assignment per line.