[alsa-devel] [PATCH 0/3] sound/usb/line6: fix some styling issues

Takashi Iwai tiwai at suse.de
Mon Jun 18 12:39:53 CEST 2018


On Mon, 18 Jun 2018 12:29:36 +0200,
Roman Sommer wrote:
> 
> CC: Jaroslav Kysela <perex at perex.cz>
> CC: Takashi Iwai <tiwai at suse.com>
> CC: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> CC: "Hans P. Möller Ebner" <hmoller at uc.cl>
> CC: Kees Cook <keescook at chromium.org>
> CC: Kate Stewart <kstewart at linuxfoundation.org>
> CC: Thomas Gleixner <tglx at linutronix.de>
> CC: "Fabián Inostroza" <soulsonceonfire at gmail.com>
> CC: Bhumika Goyal <bhumirks at gmail.com>
> CC: Philippe Ombredanne <pombredanne at nexb.com>
> CC: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> CC: alsa-devel at alsa-project.org
> CC: linux-kernel at vger.kernel.org
> 
> 
> This patchseries addresses some styling issues in sound/usb/line6 found by
> checkpatch.

Are you working further on this driver to fix any real bugs (or
implements something new), or it's an action "just because checkpatch
tells"?  I'd take such cleanup patches only for the former case.


thanks,

Takashi


> 
> Roman Sommer (3):
>   sound/line6: checkpatch: fix block comment style
>   sound/line6: unsigned -> unsigned int
>   sound/line6: add newline after declarations
> 
>  sound/usb/line6/capture.c  |  20 ++++-----
>  sound/usb/line6/driver.c   | 110 ++++++++++++++++++++++-----------------------
>  sound/usb/line6/driver.h   |  33 +++++++-------
>  sound/usb/line6/midi.c     |  24 +++++-----
>  sound/usb/line6/midibuf.c  |   6 +--
>  sound/usb/line6/pcm.c      |  26 +++++------
>  sound/usb/line6/pcm.h      |  74 +++++++++++++++---------------
>  sound/usb/line6/playback.c |  36 ++++++++-------
>  sound/usb/line6/pod.c      |  60 ++++++++++++-------------
>  sound/usb/line6/podhd.c    |   8 ++--
>  sound/usb/line6/toneport.c |  30 ++++++-------
>  sound/usb/line6/variax.c   |  40 ++++++++---------
>  12 files changed, 235 insertions(+), 232 deletions(-)
> 
> -- 
> 2.7.4
> 
> 


More information about the Alsa-devel mailing list