[alsa-devel] [PATCH 3/6] ALSA: hda/ca0132: Restore behavior of QUIRK_ALIENWARE

[Connor McAdams]

Going through the code again today, I realized why I did this. I don't
believe the Chromebook will ever go into Windows, so I don't think I
have to set the 0x797 and 0x798 audio volume verbs to 0x00 on it. I
did this so that the Alienware laptops, which probably have booted
into Windows, would have those values set to 0 if they hadn't been
already.

On Fri, Jun 15, 2018 at 9:56 PM, Alastair Bridgewater
<alastair.bridgewater at gmail.com> wrote:
> Commit e93ac30a32a6ba7ac3b4b2a4379af1dadb91e505 (ALSA: HDA/ca0132:
> add extra init functions for r3di + sbz) introduced an extra
> initialization function that was improperly guarded, taking effect
> on systems with QUIRK_ALIENWARE, even though such systems were
> supposedly not affected.
>
> It may be that this piece of initialization should be done for all
> systems, but that's not a call that I can make.
>
> Signed-off-by: Alastair Bridgewater <alastair.bridgewater at gmail.com>
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index bdd626bde267..ca7375e48138 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -7223,7 +7223,7 @@ static int ca0132_init(struct hda_codec *codec)
>
>         snd_hda_sequence_write(codec, spec->base_init_verbs);
>
> -       if (spec->quirk != QUIRK_NONE)
> +       if (spec->use_alt_functions)
>                 ca0132_alt_init(codec);
>
>         ca0132_download_dsp(codec);
> --
> 2.16.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel