[alsa-devel] [PATCH 2/2] ALSA: usb-audio: UAC3. Add insertion control for BADD.

Takashi Iwai tiwai at suse.de
Thu Jun 14 14:34:02 CEST 2018


On Tue, 12 Jun 2018 16:32:01 +0200,
Jorge Sanjuan wrote:
> 
> The HEADSET ADAPTER profile for BADD devices is meant to support
> Insertion Control for the Input and Output Terminals of the headset.
> Furthermore, this profile may also include the interrupt status pipe
> to report changes on these terminals.
> 
> This patch creates the jack-detect controls for the Headset Adapter
> profile and enables the interrupt status pipe creation for BADD devices.
> 
> Signed-off-by: Jorge Sanjuan <jorge.sanjuan at codethink.co.uk>

The changes look good, but I'd prefer splitting this:

- A preliminary work to change get_connector_control_name() and
  build_connector_control() to receive usb_mixer_interface;
  this is no functional change

- Add build_connector_control() calls for UAC3 BADD

- Apply snd_usb_mixer_status_create() for UAC3 BADD, too
  

thanks,

Takashi


More information about the Alsa-devel mailing list