[alsa-devel] [PATCH 1/8] ASoC: fsi: convert to SPDX identifiers

[Takashi Iwai]

On Tue, 12 Jun 2018 03:15:05 +0200,
Fabio Estevam wrote:
> 
> Hi Kuninori-san,
> 
> On Mon, Jun 11, 2018 at 10:11 PM, Kuninori Morimoto
> <kuninori.morimoto.gx at renesas.com> wrote:
> >
> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > ---
> >  sound/soc/sh/fsi.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
> > index 3bae06dd121f..40bafba2f3b3 100644
> > --- a/sound/soc/sh/fsi.c
> > +++ b/sound/soc/sh/fsi.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0
> >  /*
> >   * Fifo-attached Serial Interface (FSI) support for SH7724
> >   *
> > @@ -6,10 +7,6 @@
> >   *
> >   * Based on ssi.c
> >   * Copyright (c) 2007 Manuel Lauss <mano at roarinelk.homelinux.net>
> > - *
> > - * This program is free software; you can redistribute it and/or modify
> > - * it under the terms of the GNU General Public License version 2 as
> > - * published by the Free Software Foundation.
> >   */
> 
> Mark prefers that the entire block is converted to // style:
> 
> // SPDX-License-Identifier: GPL-2.0
> //
> // Fifo-attached Serial Interface (FSI) support for SH7724
> //
> // Copyright (C) 2009 Renesas Solutions Corp.
> // Kuninori Morimoto <morimoto.kuninori at renesas.com>
> //
> // Based on ssi.c
> // Copyright (c) 2007 Manuel Lauss <mano at roarinelk.homelinux.net>

... is this really the consensus as the preferred style in the whole
Linux kernel tree?  To be honest, I find it rather annoying.

It's a food for bikeshed, and in general I'd postpone such changes
unless we really have to convert.


thanks,

Takashi