[alsa-devel] unnecessary test?

Julia Lawall julia.lawall at lip6.fr
Wed Jun 6 14:39:05 CEST 2018


In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init
contains:

set_field(&ctl->spoctl, SPOCTL_OS << (idx*8),
          ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */

Could the second argument just be 2?  It's true that the preceeding call
contains conf >> ..., but in a more useful way, so perhaps it could be
useful for uniformity?

thanks,
julia



More information about the Alsa-devel mailing list