[alsa-devel] [PATCH] ASoC: topology: Increase SND_SOC_TPLG_NUM_TEXTS to 32

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Jul 20 15:58:07 CEST 2018


On 7/20/18 7:38 AM, Mark Brown wrote:
> On Fri, Jul 20, 2018 at 03:57:06PM +0530, Puneeth Prabhu wrote:
> 
>>   /* string sizes */
>> -#define SND_SOC_TPLG_NUM_TEXTS		16
>> +#define SND_SOC_TPLG_NUM_TEXTS		32
> 
> This will increase the size of the texts and values fields of at least
> snd_soc_tplg_enum_control which on the face of it appears to be an
> incompatible ABI change, topology files created with the old value will
> have a different layout for these structures to those created with the
> new one.

Agree with Mark on both points (de-duplication needed and backwards 
compatibility). If we are going to respin a new version, there are a 
couple of known limitations we may want to fix as well, such as the 
limitation to 8 channels and others I will remember once I've had more 
coffee.


More information about the Alsa-devel mailing list