[alsa-devel] [PATCH v6 07/10] soundwire: keep track of Masters in a stream

Vinod vkoul at kernel.org
Fri Jul 20 06:43:17 CEST 2018


On 19-07-18, 10:06, Pierre-Louis Bossart wrote:
> On 7/16/18 1:47 PM, Sanyog Kale wrote:
> > From: Shreyas NC <shreyas.nc at intel.com>
> > 
> > A multi link bankswitch can be done if the hardware supports and
> > the stream is handled by multiple Master(s).
> > 
> > This preparatory patch adds support to track m_rt in a stream.
> 
> The order of the patches seems off, you are adding the definition of
> m_rt_count in patch 7 but using it in patch 6, that'll break git bisect.
> What am i missing?
> 
> It'd also make more sense to have the reference counts in the same patch,
> it's hard to track otherwise, so maybe one patch to add the definitions and
> inits and the second to increase/decrease+use the value as needed.

Also it would help to have fixes first, so they go in and the bigger
changes later. That is how a series should be built typically.

-- 
~Vinod


More information about the Alsa-devel mailing list