[alsa-devel] [RFC 0/7] ASoC: rt5651: Drop pdata, move over to device-properties

Hans de Goede hdegoede at redhat.com
Thu Feb 22 18:07:31 CET 2018


Hi Mark, et al.,

Here is a second attempt to stop having duplicated DMI quirk entries
between the rt5651 codec and machine drivers.

Note this is only compile tested, I'm looking for some quick feedback if
this seems to be going in the right direction, as I'm planning on
rebuilding the rest of my jack-detect cleanup / fix series on top of
this.

The diffstat for this entire set is:

 Documentation/devicetree/bindings/sound/rt5651.txt |    6 
 include/sound/rt5651.h                             |   12 
 sound/soc/codecs/rt5651.c                          |  375 +++++++++------------
 sound/soc/codecs/rt5651.h                          |    7 
 sound/soc/intel/boards/bytcr_rt5651.c              |   46 ++
 5 files changed, 213 insertions(+), 233 deletions(-)

So besides making the code cleaner (IMHO) it also makes it somewhat smaller
and as an added bonus it fixes support the DMIC_EN quirk which was broken.

Regards,

Hans


More information about the Alsa-devel mailing list