[alsa-devel] [PATCH 04/11] ASoC: rt5651: Simplify set_bias_level()

[Mark Brown]

On Tue, Feb 20, 2018 at 11:15:04PM +0100, Hans de Goede wrote:
> There is no need to set the LDO voltage to 1.2 volt each time we enter
> standby, instead always leave it 1.2 volt on BIAS_OFF. Note we do a
> snd_soc_codec_force_bias_level(BIAS_OFF) on probe, so this will configure
> it correctly right from the start.

That force on probe sounds like a problem...  if this is being done once
at startup it should be done in the probe function, not in the bias
level configuration.

Also, are you sure this is a good fix?  If the bias voltage is being
configured all the time does that perhaps indicate that for better
performance or something it should have been being set to some other
voltage when the device is in standby?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180221/4ad1c889/attachment.sig>