[alsa-devel] [PATCH 2/3] ASoC: wm9713: Use empty struct initializer

Richard Fitzgerald rf at opensource.cirrus.com
Wed Feb 14 18:15:28 CET 2018


On 14/02/18 17:01, Fabio Estevam wrote:
> On Wed, Feb 14, 2018 at 2:56 PM, Richard Fitzgerald
> <rf at opensource.cirrus.com> wrote:
> 
>> I agree but your commit message didn't say that. It's irrelevant now
>> Mark has merged the patch, but for anyone looking at the commit message
>> later, the structure of your commit message implies that the problem
>> is that {0} doesn't work correctly (probably untrue and certainly not
> 
> Yes, and that is the message I want to give:
> 
> {0} does not work correctly if the first member of the struct is a
> pointer, as we should not explicitly write 0 to pointers.
> 

I gather that, so I'd have liked to your commit message to have said 
that. But what you actually said was

"{ 0 } only clears the first member of the structure."

which is a very different message.


More information about the Alsa-devel mailing list