[alsa-devel] [asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Feb 13 01:36:20 CET 2018


Hi Mark

> >    sound/soc/codecs/wm9705.c: In function 'wm9705_soc_probe':
> > >> sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration]
> >       wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
> >                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >                      snd_soc_new_ac97_codec
> 
> I've dropped this and the other patch that had the same issue.  I wonder
> why 0day didn't notice this on the list...

Oops, I didn't mention (?) but ac97 related code were
modified, and its related driver needs to be based on it.
Now, mark/topic/ac97 branch has it

----------------------------------------------------
commit c95869e5c04fb0000370e7310dc892b417b8128a
Author: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
Date:   Mon Jan 29 02:58:25 2018 +0000

    ASoC: ac97: replace codec to component
    
    Now we can replace Codec to Component. Let's do it.
    
    Note:
        xxx_codec_xxx()         ->      xxx_component_xxx()
        .idle_bias_off = 0      ->      .idle_bias_on = 1
        .ignore_pmdown_time = 0 ->      .use_pmdown_time = 1
        -                       ->      .endianness = 1
        -                       ->      .non_legacy_dai_naming = 1
    
    To keep compatibilty, this patch adds snd_soc_xxx_ac97_codec()
    macro. These will be removed when all codec code was removed.
    
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
    Signed-off-by: Mark Brown <broonie at kernel.org>
----------------------------------------------------



More information about the Alsa-devel mailing list