[alsa-devel] [PATCH 1/1] ALSA: virtuoso: add de-emphasis control

Tom Yan tom.ty89 at gmail.com
Wed Dec 19 19:46:33 CET 2018


Considering with my patch this is the only remaining usage of it, do
you think I should just change it into "PCM1796_DME_DISABLED" and keep
this manner (so that it is consistent with rolloff_get() /
PCM1796_FLT_SHARP)?
Or do you insist that I should use !! anyway?

On Thu, 20 Dec 2018 at 02:00, Clemens Ladisch <clemens at ladisch.de> wrote:
>
> tom.ty89 at gmail.com wrote:
> > +             (data->pcm1796_regs[0][18 - PCM1796_REG_BASE] &
> > +              PCM1796_DME) != PCM1796_DMF_DISABLED;
>
> DME and DMF are different fields.  Just use !!.
>
> With this fixed:
> Acked-by: Clemens Ladisch <clemens at ladisch.de>
>
>
> Regards,
> Clemens


More information about the Alsa-devel mailing list