[alsa-devel] [PATCH v3 02/14] ASoC: SOF: Add Sound Open Firmware KControl support

Andy Shevchenko andriy.shevchenko at intel.com
Wed Dec 12 00:25:44 CET 2018


On Tue, Dec 11, 2018 at 04:48:37PM -0600, Pierre-Louis Bossart wrote:
> > > +	max_size = (be->max < max_size) ? be->max : max_size;
> > min() / max() ?
> 
> Good catch, this can be simplified.
> 
> Not sure I like max_size = min (be->max, max_size), it's confusing.

Hmm... It shows intention. For _max size_ you choose _minimum_ value out of two.

> 
> Maybe
> 
> if (be->max < max_size)
> 
>     max_size = be->max;

It's minor, just choose one style and use it.

-- 
With Best Regards,
Andy Shevchenko




More information about the Alsa-devel mailing list