[alsa-devel] [PATCH v3 3/3] ASoC: Add Multi CPU DAI support in DAPM

Charles Keepax ckeepax at opensource.cirrus.com
Mon Apr 30 18:24:56 CEST 2018


On Thu, Apr 19, 2018 at 03:19:19PM +0530, Vinod Koul wrote:
> From: Shreyas NC <shreyas.nc at intel.com>
> 
> Extend the multi CPU support in DAPM functions to check for
> valid widgets and connected widgets.
> 
> Signed-off-by: Shreyas NC <shreyas.nc at intel.com>
> Signed-off-by: Vinod Koul <vinod.koul at intel.com>
> ---
> +static void dapm_add_valid_dai_widget(struct snd_soc_card *card,
> +					struct snd_soc_pcm_runtime *rtd,
> +					struct snd_soc_dai *codec_dai,
> +					struct snd_soc_dai *cpu_dai)

This function name still feels a little funny since the function
doesn't add any widgets. It adds paths if there are valid
widgets. Perhaps dapm_add_valid_dai_path?

But I don't feel super strongly about it, so:

Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>

Thanks,
Charles


More information about the Alsa-devel mailing list