[alsa-devel] [PATCH v3] ASoC: dapm: Avoid creating kcontrol for params

Charles Keepax ckeepax at opensource.cirrus.com
Fri Sep 29 11:09:38 CEST 2017


On Thu, Sep 28, 2017 at 09:52:39PM -0700, yesanishhere at gmail.com wrote:
> From: anish kumar <yesanishhere at gmail.com>
> 
> Currently in codec to codec dai link if there are multiple
> params defined then dapm can use created kcontrol to
> decide which param to apply at runtime.
> 
> However, in case there is only single param configuration
> then there is no point in creating the kcontrol and also there
> is no point in allocating memory for kcontrol.
> 
> In the snd_soc_dapm_new_pcm function, there is memory
> allocation happening for kcontrol which is later used
> or not used based on num_param. It is better to not
> allocate memory when there is only a single configuration.
> This change is to remedy that anomaly.
> 
> Signed-off-by: anish kumar <yesanishhere at gmail.com>
> ---

Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>
Tested-by: Charles Keepax <ckeepax at opensource.cirrus.com>

Thanks,
Charles


More information about the Alsa-devel mailing list