[alsa-devel] [PATCH v2] ASoC: dapm: Avoid creating kcontrol for params

[Charles Keepax]

On Wed, Sep 27, 2017 at 02:08:25PM -0700, anish kumar wrote:
> On Wed, Sep 27, 2017 at 3:11 AM, Charles Keepax
> <ckeepax at opensource.cirrus.com> wrote:
> > On Tue, Sep 26, 2017 at 09:11:11PM -0700, yesanishhere at gmail.com wrote:
> >> From: anish kumar <yesanishhere at gmail.com>
> >>
> >> Currently in codec to codec dai link if there are multiple
> >> params defined then dapm can use created kcontrol to
> >> decide which param to apply at runtime.
> >>
> >> However, in case there is only single param configuration
> >> then there is no point in creating the kcontrol and also there
> >> is no point in allocating memory for kcontrol.
> >>
> >> In the snd_soc_dapm_new_pcm function, there is memory
> >> allocation happening for kcontrol which is later used
> >> or not used based on num_param. It is better to not
> >> allocate memory when there is only a single configuration.
> >> This change is to remedy that anomaly.
> >>
> >> Signed-off-by: anish kumar <yesanishhere at gmail.com>
> >> ---
> 
> No, as this is getting freed in the common function.
> >

Apologies so it.

Thanks,
Charles