[alsa-devel] [PATCH] ASoC: soc-core: remove rtd NULL check from soc_free_pcm_runtime()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Sep 11 10:32:19 CEST 2017


From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

static soc_free_pcm_runtime() is never called with rtd==NULL.
This patch removes unnecessary rtd == NULL check from
soc_free_pcm_runtime().
Otherwise it logically inconsistent.

Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
 sound/soc/soc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 19f6d07..ee29d7c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -407,7 +407,7 @@ static struct snd_soc_pcm_runtime *soc_new_pcm_runtime(
 
 static void soc_free_pcm_runtime(struct snd_soc_pcm_runtime *rtd)
 {
-	if (rtd && rtd->codec_dais)
+	if (rtd->codec_dais)
 		kfree(rtd->codec_dais);
 	snd_soc_rtdcom_del_all(rtd);
 	kfree(rtd);
-- 
1.9.1



More information about the Alsa-devel mailing list