[alsa-devel] [PATCH 3/3] ASoC: wm8741: Set SR mode in hw_params()

[Charles Keepax]

On Tue, Sep 05, 2017 at 09:05:27PM +0200, Sergej Sawazki wrote:
> Am 05.09.2017 um 18:23 schrieb Charles Keepax:
> > On Mon, Sep 04, 2017 at 09:34:13PM +0200, Sergej Sawazki wrote:
> > > Set the ratio of MCLK/LRCLK in hw_params() instead of relying on the
> > > auto-detection.
> > > 
> > > The ratio of MCLK/LRCLK is known to the driver, there is no need to let
> > > the device to detect it.
> > > 
> > 
> > But also no reason to not let it do so, are there some problems
> > with the auto-detect?
> > 
> 
> I haven't noticed any problems. But, as we know the ratio and the device
> provides an interface to set it, why don't we just do it?
> Setting it feels right somehow, even if it is not absolutely necessary.
> 

I would lean more towards if the auto-detect works we might as
well use it and not add code we don't need.

Thanks,
Charles