[alsa-devel] [PATCH 1/3] ASoC: wm8741: Add digital mute callback

[Sergej Sawazki]

Thanks Charles,

agreed about the __func__. But, I would like to keep the debug message, 
in order to be consistent with the other callbacks. They all print debug 
messages.

Would it be ok for you?

Regards,
Sergej

Am 05.09.2017 um 15:33 schrieb Charles Keepax:
> On Mon, Sep 04, 2017 at 09:34:11PM +0200, Sergej Sawazki wrote:
>> Signed-off-by: Sergej Sawazki <sergej at taudac.com>
>> ---
>>   sound/soc/codecs/wm8741.c | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c
>> index b8c1940..d552a8a 100644
>> --- a/sound/soc/codecs/wm8741.c
>> +++ b/sound/soc/codecs/wm8741.c
>> @@ -351,6 +351,17 @@ static int wm8741_set_dai_fmt(struct snd_soc_dai *codec_dai,
>>   	return 0;
>>   }
>>   
>> +int wm8741_mute(struct snd_soc_dai *codec_dai, int mute)
>> +{
>> +	struct snd_soc_codec *codec = codec_dai->codec;
>> +
>> +	dev_dbg(codec->dev, "%s:    mute = %d\n", __func__, mute);
> 
> Its not really normal style to use __func__ in this sort of
> print, just make it descriptive of what it does. Although I would
> also say you could just drop it as well if you fancied it is a
> little verbose even for debug output.
> 
> Otherwise this patch looks ok to me.
> 
> Thanks,
> Charles
>