[alsa-devel] [PATCH v2 2/2] ASoC: cs43130: Fix unused compiler warnings for PM runtime

Takashi Iwai tiwai at suse.de
Mon Sep 4 16:34:47 CEST 2017


On Mon, 04 Sep 2017 16:31:03 +0200,
Daniel Baluta wrote:
> 
> On Lu, 2017-09-04 at 15:54 +0200, Takashi Iwai wrote:
> > Add __maybe_unused prefix for addressing the following warnings:
> >   sound/soc/codecs/cs43130.c:2615:12: warning: ‘cs43130_runtime_resume’ defined but not used [-Wunused-function]
> >   sound/soc/codecs/cs43130.c:2596:12: warning: ‘cs43130_runtime_suspend’ defined but not used [-Wunused-function]
> > 
> 
> Isn't it better to guard it with CONFIG_PM?

It's a matter of taste, and people seem prefer this option nowadays,
so I follow that style.


Takashi


More information about the Alsa-devel mailing list