[alsa-devel] [PATCH v2] ASoC: wm8741: Add digital mute callback

Mark Brown broonie at kernel.org
Mon Oct 30 17:13:35 CET 2017


On Mon, Oct 30, 2017 at 03:41:35PM +0000, Charles Keepax wrote:
> On Mon, Oct 30, 2017 at 09:28:16AM +0100, Sergej Sawazki wrote:

> > +	dev_dbg(codec->dev, "wm8741_mute:    mute = %d\n", mute);

> It is still not really normal style to include the function name
> in the debug messages. How about just "digital mute = %d\n" or
> something like that?

Or just don't log anything and rely on framework level diagnostics if
they're needed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20171030/d3fc7801/attachment-0001.sig>


More information about the Alsa-devel mailing list