[alsa-devel] [PATCH] ALSA: seq: Enable 'use' locking in all configurations

Takashi Iwai tiwai at suse.de
Wed Oct 18 08:03:10 CEST 2017


On Wed, 18 Oct 2017 01:45:49 +0200,
Ben Hutchings wrote:
> 
> The 'use' locking macros are no-ops if neither SMP or SND_DEBUG is
> enabled.  This might once have been OK in non-preemptible
> configurations, but even in that case snd_seq_read() may sleep while
> relying on a 'use' lock.  So always use the proper implementations.
> 
> Cc: stable at vger.kernel.org
> Signed-off-by: Ben Hutchings <ben.hutchings at codethink.co.uk>

Yeah, this conditional build makes little sense nowadays although it
was meaningful in 20 years ago.

Applied now, thanks.


Takashi


More information about the Alsa-devel mailing list