[alsa-devel] [PATCH] dmaengine: imx-sdma: advertise all supported slave bus widths

[Lucas Stach]

Am Montag, den 16.10.2017, 12:21 +0530 schrieb Vinod Koul:
> On Fri, Oct 13, 2017 at 12:43:46PM +0200, Lucas Stach wrote:
> > The commit [1] which changed imx-pcm-dma to derive the pcm_config
> > from the
> 
> Commit 70d435ba1cd6 (...) changed... please
> 
> > attached dmaengine introduced a regression on the supported sample
> > formats,
> > as imx-sdma doesn't properly advertise all the supported slave bus
> > widths.
> > 
> > Fix this to restore full functionality of the imx sound subsystem.
> > 
> > [1] 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
> 
> Fixes: 70d435ba1cd6 ... please

Nope, it isn't strictly a fix for this commit, which is why I didn't
mark it as such. It's a separate fix, which fixes a bad interaction
between dmaengine and sound, but it may also affect other users.

Regards,
Lucas

> 
> > > > Signed-off-by: Lucas Stach <l.stach at pengutronix.de>
> > ---
> >  drivers/dma/imx-sdma.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> > index a67ec1bdc4e0..e374183f19d0 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -1851,8 +1851,12 @@ static int sdma_probe(struct platform_device *pdev)
> > > >  	sdma->dma_device.device_prep_dma_cyclic = sdma_prep_dma_cyclic;
> > > >  	sdma->dma_device.device_config = sdma_config;
> > > >  	sdma->dma_device.device_terminate_all = sdma_disable_channel_with_delay;
> > > > -	sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
> > > > -	sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
> > > > +	sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) |
> > > > +					   BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) |
> > > > +					   BIT(DMA_SLAVE_BUSWIDTH_1_BYTE);
> > > > +	sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) |
> > > > +					   BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) |
> > > > +					   BIT(DMA_SLAVE_BUSWIDTH_1_BYTE);
> > > >  	sdma->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> > > >  	sdma->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
> > > >  	sdma->dma_device.device_issue_pending = sdma_issue_pending;
> > -- 
> > 2.11.0
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>