[alsa-devel] [PATCH] ALSA: seq: Fix use-after-free at creating a port

Takashi Iwai tiwai at suse.de
Wed Oct 11 20:05:08 CEST 2017


On Wed, 11 Oct 2017 19:35:46 +0200,
Linus Torvalds wrote:
> 
> On Wed, Oct 11, 2017 at 1:00 AM, Takashi Iwai <tiwai at suse.de> wrote:
> > There is a potential race window opened at creating and deleting a
> > port via ioctl, as spotted by fuzzing.   [..]
> 
> I'm assuming I'll just get this through the normal sound fixes pull request?

Yes, I'll send you a pull request tomorrow together with other fixes.

> Also, just for future issues, I really wish people would edit the call
> traces to be a bit more legible. You did remove some of the excessive
> KASAN noise, but the stack trace hex numbers are a bit distracting
> too.
> 
> Of course, the only reason those hex numbers are there in the first
> place was that the oops was generated with an older kernel - we don't
> even print them out any more.
> 
> Not a big deal, but I thought I'd mention it just because I generally
> encourage people to try to edit down oopses etc to the really relevant
> parts (the kernel often spits out a lot of stuff that isn't really
> relevant for the particular bug, because it *might* be)

OK, noted.

Now after seeing lots of commits with stack trace messages in this
week (I warn you beforehand!), I share the same feeling.
Will tidy up harder at the next time.


Thanks!

Takashi


More information about the Alsa-devel mailing list