[alsa-devel] [PATCH 0/5] ASoC: cleanup random snd_soc_read/write - step [4/6]

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Nov 14 02:03:28 CET 2017


Hi Mark

Previous step [3/6] will be applied after merge window,
thus, I try to post next step [4/6].

Current Codec framework is supporting its original reg_cache,
but, we have "regmap" now, and common snd_soc_component_read/write
are using it. This "legacy reg_cache" user driver is using its own
xxx_read/write which is using reg_cache inside.
If we can copy "Codec framework reg_cache" into its driver,
we can remove original reg_cache from Codec framework.
No problem, the user driver is very few.
Let's do it (and remove original reg_cache in the future)
(= for [1/5][2/5][3/5]).
About [3/5] case, cx20442 driver is using reg_cache, but
it is only for 1byte at this point. and this driver doesn't use
snd_soc_write/read (which is using reg_cache). The reg_cache user
is only debugfs. Let's just clean reg_cache for now, but
keep cx20442_write. It seems Lars-Peter has some plan/patch for this
driver, and it will update read/write related things which will use
this cx20442_write.

Our common snd_soc_read/write is wrapper of snd_soc_component_read/write now.
snd_soc_component_read/write will try to use regmap first. And will try
Codec framework's original .read/.write if driver doesn't use regmap.
But, almost all driver which doesn't use regmap is using their original
xxx_read/write instead of snd_soc_component_read/write.
We can remove Codec framework's .read/.write if all these driver uses
its own xxx_read/write instead of snd_soc_read/write
(= for [4/5][5/5]).

Kuninori Morimoto (5):
  ASoC: use internal reg_cache on uda1380
  ASoC: use internal reg_cache on tlv320dac33
  ASoC: cx20442: don't use reg_cache
  ASoC: don't use snd_soc_write/read on twl6040
  ASoC: don't use snd_soc_write/read on twl4030

 sound/soc/codecs/cx20442.c     | 21 ++++-----------------
 sound/soc/codecs/tlv320dac33.c | 33 +++++++++++++--------------------
 sound/soc/codecs/twl4030.c     | 10 ++++------
 sound/soc/codecs/twl6040.c     |  4 +---
 sound/soc/codecs/uda1380.c     | 24 ++++++++++++++----------
 5 files changed, 36 insertions(+), 56 deletions(-)

-- 
1.9.1



More information about the Alsa-devel mailing list