[alsa-devel] [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

[Takashi Iwai]

On Wed, 17 May 2017 13:38:56 +0200,
Bhumika Goyal wrote:
> 
> Declare snd_kcontrol_new structures as const as they are only passed an
> argument to the function snd_ctl_new1. This argument is of type const,
> so snd_kcontrol_new structures having this property can be made const.
> Done using Coccinelle:
> 
> @r disable optional_qualifier@
> identifier x;
> position p;
> @@
> static struct snd_kcontrol_new x at p={...};
> 
> @ok@
> identifier r.x;
> position p;
> @@
> snd_ctl_new1(&x at p,...)
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.x;
> @@
> x at p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.x;
> @@
> +const
> struct snd_kcontrol_new x;
> 
> Signed-off-by: Bhumika Goyal <bhumirks at gmail.com>

As I already asked, could you send as a patchset if you have multiple
similar patches?


thanks,

Takashi