[alsa-devel] [PATCH 1/3] ASoC: Intel: Skylake: Fix IPC rx_list corruption

Vinod Koul vinod.koul at intel.com
Tue May 16 08:11:11 CEST 2017


On Mon, May 15, 2017 at 07:44:29PM +0530, Subhransu S. Prusty wrote:
> From: Pardha Saradhi K <pardha.saradhi.kesapragada at intel.com>
> 
> In SKL+ platforms, all IPC commands are serialised, i.e. the driver sends
> a new IPC to DSP, only after receiving a reply from the firmware for the
> current IPC.
> 
> Hence it seems apparent that there is only a single modifier of the IPC RX
> List. However, during an IPC timeout case in a multithreaded environment,
> there is a possibility of the list element being deleted two times if not
> properly protected.
> 
> So, use spin lock save/restore to prevent rx_list corruption.

Looks good, all three:

Acked-by: Vinod Koul <vinod.koul at intel.com>

-- 
~Vinod


More information about the Alsa-devel mailing list