[alsa-devel] [PATCH v2] ASoC: intel: Don't print FW version repeatedly

Takashi Iwai tiwai at suse.de
Mon Mar 27 14:17:00 CEST 2017


Intel SST driver spews an info message "FW Versoin xxxx" at each time
the device gets initialized.  Since it's triggered at each PM (or even
runtime PM), it appears too frequently, which is rather annoying.
Moreover, the firmware in the driver is cached, thus it's assured to
be always the same version once after loaded; i.e. it's superfluous to
show the same version number repeatedly.

This patch suppresses the superfluous messages by replacing with
dev_info_once().

Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
v1->v2: Use dev_info_oce()

 sound/soc/intel/atom/sst/sst_ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c
index 14c2d9d18180..65f3696133d3 100644
--- a/sound/soc/intel/atom/sst/sst_ipc.c
+++ b/sound/soc/intel/atom/sst/sst_ipc.c
@@ -236,7 +236,7 @@ static void process_fw_init(struct intel_sst_drv *sst_drv_ctx,
 		retval = init->result;
 		goto ret;
 	}
-	dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n",
+	dev_info_once(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n",
 			init->fw_version.type, init->fw_version.major,
 			init->fw_version.minor, init->fw_version.build);
 	dev_dbg(sst_drv_ctx->dev, "Build date %s Time %s\n",
-- 
2.11.1



More information about the Alsa-devel mailing list