[alsa-devel] [PATCH] ASoC: core: remove redundunt address operation for array type variable

Mark Brown broonie at kernel.org
Mon Mar 13 17:54:19 CET 2017


On Mon, Mar 13, 2017 at 12:07:43PM +0900, Takashi Sakamoto wrote:

> These two evaluation have the same value, a pointer to the first element
> of the array.

> This kind of address operation is not good for readers, because it easily
> brings confusions as an address operations to pointers. For example,

This is done explicitly for clarity, in order to make it clear that the
value is a pointer rather than being (say) an integer.  The value is the
same as you say but that's only clear if the reader realizes that data
is an array.  If I were clarifying this I'd change to explicitly take
the address of the first element of the array rather than the array as
a whole. 

> Cc: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> Fixes: f831b055ecec ("ASoC: core: Add support for masking out parts of coefficient blocks")

This is a style change rather than a fix.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20170313/1747f726/attachment.sig>


More information about the Alsa-devel mailing list