[alsa-devel] [PATCH v2] ALSA: core: let low-level driver or userspace disable rewinds

Clemens Ladisch clemens at ladisch.de
Mon Jun 12 08:50:38 CEST 2017


Subhransu S. Prusty wrote:
> Add new hw_params flag to explicitly tell driver that rewinds will never
> be used. [...]

> +++ b/sound/core/pcm_native.c
> @@ -2521,6 +2523,9 @@ static snd_pcm_sframes_t snd_pcm_playback_rewind(struct snd_pcm_substream *subst
>  	if (frames == 0)
>  		return 0;
>
> +	if (runtime->no_rewinds)
> +		return 0;

Doing a rewind when you've promised not to is an error.  So why doesn't
this return an error code?


Regards,
Clemens


More information about the Alsa-devel mailing list