[alsa-devel] [PATCH v2] ASoC: Intel: byt-max98090: Add GPIO ACPI mapping table

[Takashi Iwai]

On Sat, 10 Jun 2017 18:37:41 +0200,
Andy Shevchenko wrote:
> 
> +static const struct acpi_gpio_params hp_gpios = { 0, 0, false };
> +static const struct acpi_gpio_params mic_gpios = { 1, 0, false };
> +
> +static const struct acpi_gpio_mapping acpi_byt_max98090_gpios[] = {
> +	{ "hp-gpios", &hp_gpios, 1 },
> +	{ "mic-gpios", &mic_gpios, 1 },

Better to use C99 style init?  I'm not always a fan of it, but this
seems deserving.  From the above, it's difficult to know which zero is
for what.


thanks,

Takashi