[alsa-devel] [PATCH v1] ASoC: Intel: byt-max98090: Add GPIO ACPI mapping table

Andy Shevchenko andriy.shevchenko at linux.intel.com
Sat Jun 10 13:32:50 CEST 2017


On Fri, 2017-06-09 at 22:19 +0300, Andy Shevchenko wrote:
> On Fri, 2017-06-09 at 12:12 -0700, Dmitry Torokhov wrote:
> > On Fri, Jun 9, 2017 at 11:38 AM, Andy Shevchenko
> > <andriy.shevchenko at linux.intel.com> wrote:
> > > In order to make GPIO ACPI library stricter prepare users of
> > > gpiod_get_index() to correctly behave when there no mapping is
> > > provided by firmware.
> > > 
> > > Here we add explicit mapping between _CRS GpioIo() resources and
> > > their names used in the driver.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > 
> > This is a bit more verbose than simply using the same connection
> > name,
> > but I guess will provide better diagnostic to userspace as we will
> > have distinct GPIO names.
> > 
> > Reviewed-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> 
> Thanks!
> 
> But please test it.


I have to check the device node I'm attaching the mapping table to.

On deeper glance it looks now wrong (attaching table to the card
platform device when it should be codec's one?). 

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the Alsa-devel mailing list