[alsa-devel] [PATCH] ALSA: firewire: arrange common PCM info/constraints for AMDTP engine applications

Takashi Iwai tiwai at suse.de
Thu Jun 8 09:16:40 CEST 2017


On Thu, 08 Jun 2017 02:11:03 +0200,
Takashi Sakamoto wrote:
> 
> In ALSA firewire stack, 8 drivers uses IEC 61883-1/6 engine for data
> transmission. They have common PCM info/constraints and duplicated codes.
> 
> This commit unifies the codes into fireiwre-lib.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> ---
>  sound/firewire/amdtp-stream.c            | 19 +++++++++++++++++
>  sound/firewire/bebob/bebob_pcm.c         | 21 -------------------
>  sound/firewire/dice/dice-pcm.c           | 20 ------------------
>  sound/firewire/digi00x/digi00x-pcm.c     | 33 ++++++++++--------------------
>  sound/firewire/fireface/ff-pcm.c         | 21 -------------------
>  sound/firewire/fireworks/fireworks_pcm.c | 21 -------------------
>  sound/firewire/motu/motu-pcm.c           | 20 ------------------
>  sound/firewire/oxfw/oxfw-pcm.c           | 20 ------------------
>  sound/firewire/tascam/tascam-pcm.c       | 35 ++++++--------------------------
>  9 files changed, 36 insertions(+), 174 deletions(-)

Lovely, lots of code reduction.

Applied now.  Thanks.


Takashi


More information about the Alsa-devel mailing list